Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new scripts for the DB access #317

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Added new scripts for the DB access #317

merged 5 commits into from
Sep 19, 2024

Conversation

smjmoj
Copy link

@smjmoj smjmoj commented Sep 11, 2024

Add connection files to gitignore we don't want to commit those.

Created new Make targets for DB connections
Make it really easy for an engineer to get the information for connecting to the RDS DB from the bastion when debugging issues.

Update the documentation for RDS Bastion
reflect new changes since AWS Secrets have been used and the explain to use the new make targets. ND-510

Add connection files to gitignore we don't want to commit those.

Created new Make targets for DB connections
Make it really easy for an engineer to get the information for connecting to the RDS DB from the bastion when debugging issues.

Update the documentation for RDS Bastion
reflect new changes since AWS Secrets have been used and the explain to use the new make targets.
ND-510
@smjmoj smjmoj requested a review from a team as a code owner September 11, 2024 10:57
@smjmoj smjmoj requested review from dms1981, kyphutruong and jamesgreen-moj and removed request for a team September 11, 2024 10:57
@github-actions github-actions bot added documentation Improvements or additions to documentation network-access-control labels Sep 11, 2024
Copy link
Contributor

@laurentb4 laurentb4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smjmoj smjmoj merged commit aa646a1 into main Sep 19, 2024
@smjmoj smjmoj deleted the ND-510-DB-CLI-Update branch September 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation network-access-control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants